SEZ9 commented on PR #11564: URL: https://github.com/apache/seatunnel/pull/11564#issuecomment-5358316750
Thanks @DanielLeens for the detailed re-verification, and @nzw921rx for the +1. The diff evidence is exactly what I needed: confirming that the two files in this PR's diff (`ReportMetricsOperation.java` and `ReportMetricsOperationTest.java`) are byte-for-byte identical between `2553537c465f`, `e22ffca5e440`, and the current head `e01712f9`, with the only new commit being the merge of `dev`, means there is no new logic delta to review. Since the merge picked up no changes to the PR's files, my earlier ask to merge exactly `e22ffca5e` is satisfied in substance — we'd now merge `e01712f9`, which carries the identical source. Two concrete remaining asks before merge: 1. Please confirm no further pushes are planned on this head so we merge exactly `e01712f9`. 2. The non-blocking test-stability note on `ReportMetricsOperationTest.shouldKeepRemoteGenericOperationsResponsiveWhileMetricsWaitForOffloadExecutor` still needs a follow-up tracker — a short summary of the suggested improvement in a new issue would be enough so it doesn't get lost after merge. Once those are in place, I'll proceed with the merge. Thanks both for the careful reviews on this one. <!-- streview-comment:393 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
