DanielLeens commented on PR #11564: URL: https://github.com/apache/seatunnel/pull/11564#issuecomment-5389993355
Thanks @SEZ9 — agreed on all three points, and nothing new from me on the source side. Just checked live again: `Build` on `e01712f9` is still `failure` for the same jobs we already discussed (`unit-test (11, windows-latest)`, `engine-v2-it (8, ubuntu-latest)`, `all-connectors-it-7 (11, ubuntu-latest)`, `doris-connector-it (8, ubuntu-latest)`), none of which touch `ReportMetricsOperation`/`ReportMetricsOperationTest`. So the rerun still hasn't happened yet — that action item is still with @nielifeng. To be precise about what "nothing further from review side" means: my APPROVED conclusion from 08-04 stands, reaffirmed multiple times since (most recently 08-22) with the diff confirmed byte-for-byte unchanged each time. Once the failed jobs are rerun and `Build` comes back green on this same head, there's no additional review step needed from me before merge. On the tracking issue for the `shouldKeepRemoteGenericOperationsResponsiveWhileMetricsWaitForOffloadExecutor` timeout-centralization note — appreciate you taking that on post-merge, that keeps it from getting lost. @nielifeng — whenever you get a chance, a rerun of just the failed jobs on `e01712f9` and a note here once green would unblock this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
