SEZ9 commented on PR #10340: URL: https://github.com/apache/seatunnel/pull/10340#issuecomment-5390957600
Thanks @DanielLeens for the clear status confirmation — answering your comment directly: You're right that the head is still `9445ffdbc522` and nothing new has landed yet, so there is nothing for you to re-review at this point. Your summary of what remains outstanding matches mine: - The decimal precision cap (Issues 1/2 from your Aug 6 review) — not yet addressed. - The `JdbcOscarUpsetIT` cleanup-schema fix (Issue 3) — not yet addressed. - The XA `xa_data_source_class_name` doc correction in `docs/en/connectors/sink/Jdbc.md` — the documented `com.oscar.xa.Jdbc3XAConnection` is an XAConnection, not an XADataSource, and still needs to be replaced with the correct XADataSource class. - Confirmation that the new Oscar E2E ITs actually run in CI — we still need a publicly pullable Oscar container image reference (or an explanation of how the tests execute); without that we can't verify they aren't permanently skipped. - Reverting the whole-table reformat in `docs/en/connectors/sink/Jdbc.md` so the diff only shows the meaningful Oscar row addition. - Syncing the branch with `dev` to clear the reported merge conflicts. So to be plain: none of these are done yet, and all of them need a new commit before this can move forward. Once the branch is updated to cover the items above, please leave a comment here and @DanielLeens and I will do the full re-review together — no need for repeated pings before then. Thanks again to everyone keeping this thread active; the contribution itself is architecturally sound and we'd like to get it over the line. <!-- streview-comment:501 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
