DanielLeens commented on PR #10340:
URL: https://github.com/apache/seatunnel/pull/10340#issuecomment-5412503018

   Thanks @SEZ9 for keeping this current, and thanks @dsomehan for staying 
engaged. I independently re-checked the live PR state before replying: the head 
is still `9445ffdbc5220b416fb146b74a839e50bac0c981`, `mergeable=false` / 
`mergeable_state=dirty` (the `dev` sync is indeed still outstanding), and the 
only check-run on this head is still the `Build` job from 2026-01-26 
(https://github.com/apache/seatunnel/runs/61430200382, conclusion `failure`) -- 
nothing newer has run. So the status posted here matches what I see directly 
from the API.
   
   Given this is now several days of confirming the same unchanged status, here 
is the concrete list once more in one place so it's easy to act on in a single 
pass, and then I'll hold off on repeating it further:
   
   1. Normalize Oscar `NUMBER/NUMERIC/DECIMAL` precision/scale so source schema 
inference cannot produce `Decimal(1000,38)` (my original Issues 1/2 from the 
2026-04-20 review).
   2. Fix `JdbcOscarUpsetIT` cleanup to target the `SYSDBA2` schema instead of 
falling back to `OSRDB` (my original Issue 3).
   3. Correct the documented `xa_data_source_class_name` in 
`docs/en/connectors/sink/Jdbc.md` -- `com.oscar.xa.Jdbc3XAConnection` is an 
`XAConnection`, not a `javax.sql.XADataSource`, so exactly-once mode will fail 
at job start for anyone who follows the docs as written.
   4. Confirm (in the PR description, or here) that the new Oscar E2E ITs run 
against a publicly pullable container image rather than being silently skipped.
   5. Revert the whole-table column-width reformat in 
`docs/en/connectors/sink/Jdbc.md` so the diff shows only the meaningful new row.
   6. Rebase onto the current `dev` to clear the reported merge conflicts, and 
push a fresh head so `Build` runs against the actual diff.
   
   Once a new commit covering these lands, I'll do a full re-review right away. 
No need to keep re-confirming this same status daily -- I'll pick it back up as 
soon as the branch moves.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to