SEZ9 commented on PR #10340: URL: https://github.com/apache/seatunnel/pull/10340#issuecomment-5409363331
Thanks @DanielLeens — sorry for the delayed reply. Confirming your summary is accurate: the head is still `9445ffdbc522`, so nothing on your list has been addressed yet. All items remain outstanding: 1. The decimal precision cap on the source-read path (your Issues 1/2). 2. The `JdbcOscarUpsetIT` cleanup-schema fix (Issue 3). 3. The `xa_data_source_class_name` doc correction in `docs/en/connectors/sink/Jdbc.md` — the documented `com.oscar.xa.Jdbc3XAConnection` is an XAConnection, not an XADataSource, so exactly-once mode will fail for anyone who copies it as-is. 4. Confirmation that the new Oscar E2E ITs run against a publicly pullable container image rather than being permanently skipped — a note in the PR description pointing at the image reference would settle this. 5. Reverting the whole-table reformat in the docs diff so the Oscar row is the only visible change. 6. The `dev` sync to clear the reported merge conflicts. Concrete asks for the author before the next round: push a commit covering items 1–3 and 5, rebase onto `dev` for item 6, and either link the pullable image or explain how the ITs are expected to run in CI for item 4. Once a fresh commit lands, @DanielLeens and I will re-review together — no need to re-ping until then. <!-- streview-comment:537 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
