DanielLeens commented on PR #11937:
URL: https://github.com/apache/seatunnel/pull/11937#issuecomment-5462260889

   Thanks for the update. I checked the current head against the latest `dev` 
and this branch is
   currently behind upstream (`behind_by=64`, compare status: `diverged`). The 
current failing CI
   signal does not appear to be directly caused by this PR's diff yet — the 
`Transforms : V2` module
   itself builds and tests clean in the same run, and the Windows unit-test job 
actually fails in an
   unrelated module (`connector-python`, 
`PythonSourceTest#testConcurrentCloseStopsBufferedBatchEmission`),
   which was already made deterministic upstream in `dev` via #11906 after this 
branch's base was cut.
   So the lowest-cost next step is to sync with the latest `dev` and rerun CI 
first. If it still fails
   after the sync, I can help narrow it down against the updated head.
   
   (Separately, on the merge-gate sidebar: as noted in my previous comment, my 
approval from `0a6d6d9d6`
   still stands on the implementation side — the outstanding 
`CHANGES_REQUESTED` is a stale review-state
   display issue, not a code concern from me.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to