SEZ9 commented on PR #11937: URL: https://github.com/apache/seatunnel/pull/11937#issuecomment-5469329356
Thanks @goutamadwant for the re-review and approval, and thanks @DanielLeens for confirming your earlier approval from `0a6d6d9d6` still stands and for clarifying the stale `CHANGES_REQUESTED` display — with both approvals in, the review-state question is settled and there are no further code changes being requested from the reviewers' side. That leaves one concrete item before this can move forward, as @DanielLeens already flagged: the branch is still `behind_by=64` / `diverged` against `dev`, and the `Build` check is showing `FAILURE`. Since the `connector-python` flake was already fixed upstream in `dev` via #11906 (and the `Transforms : V2` module itself builds and tests clean per @DanielLeens's check), please: 1. Sync this branch with the latest `dev`. 2. Re-run CI on the updated head. Once CI is green after the sync we can take a fresh look at the result and get this merged. If the failure persists after syncing, @DanielLeens has offered to help narrow it down against the updated head, so just report back here. <!-- streview-comment:682 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
