zhang-arvin commented on PR #11866: URL: https://github.com/apache/seatunnel/pull/11866#issuecomment-5469109226
@DanielLeens Thanks for the thorough re-review! I have addressed the remaining blocker: Issue 2 (test coverage): Added two new test methods that actually instantiate SimpleJdbcConnectionProvider and call getOrEstablishConnection(): 1. testGetOrEstablishConnectionFallsBackWhenDriverRejectsUrl — Registers a RejectingDriver (whose acceptsURL returns false) and an AcceptingDriver. Constructs SimpleJdbcConnectionProvider with driverName set to the rejecting driver class name, calls getOrEstablishConnection(), and verifies the connection is obtained from the accepting driver via the DriverManager fallback. 2. testGetOrEstablishConnectionFallsBackWhenDriverThrowsOnAcceptsUrl — Registers a ThrowingDriver (whose acceptsURL throws SQLException) and an AcceptingDriver. Verifies the exception path falls back correctly. Supporting classes RejectingDriver and ThrowingDriver are package-private classes in the test package, so loadDriver() can match them by getClass().getName(). Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
