zhang-arvin commented on PR #11866: URL: https://github.com/apache/seatunnel/pull/11866#issuecomment-5474889220
@DanielLeens Thanks for the thorough review! Addressed: 1. Added `testDriverDisambiguationInGetConnection` in `AbstractJdbcCatalogTest` — registers two `ConfigurableDriver` instances with the same class name (one rejecting, one accepting), calls `getConnection()` directly, and asserts the connection comes from the accepting driver via the per-driver loop rather than the outer `DriverManager.getConnection()` fallback. This closes the remaining `AbstractJdbcCatalog` half of Issue 2. 2. Merged `acceptsURL()` and `connect()` into the same per-driver `try/catch` block in `AbstractJdbcCatalog.getConnection()` so a single driver throwing from `acceptsURL()` only skips that driver rather than aborting the entire enumeration. 3. Cached the corrected driver in `SimpleJdbcConnectionProvider.loadedDriver` after the `DriverManager.getDriver(url)` fallback succeeds, so the fallback doesn't repeat on every reconnect. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
