DanielLeens commented on PR #11866: URL: https://github.com/apache/seatunnel/pull/11866#issuecomment-5480645833
CI record update: the previously in-progress jobs at this head (`06ba93ef`, fork run `zhang-arvin/seatunnel#33366335404`) have since completed. Two new job failures appeared that were not visible when I posted my last review — `doris-connector-it (8, ubuntu-latest)` and `doris-connector-it (11, ubuntu-latest)`, both failing on the identical assertion `DorisErrorIT.testDoris:85 expected: <true> but was: <false>`. This is unrelated to this PR's diff: `connector-doris` does not use `AbstractJdbcCatalog` or `SimpleJdbcConnectionProvider` (confirmed via code search — zero references), and the same failure on both JDK 8 and JDK 11 points to a pre-existing dev-side test issue rather than something introduced here. (`updated-modules-integration-test-part-7 (8, ubuntu-latest)` and `paimon-connector-it (8, ubuntu-latest)` were cancelled as a downstream side effect of the run failing, not independent failures.) My prior conclusion stands: the PR-scoped diff itself (the 4 JDBC files) is clean, all unit-test jobs are green, and the previously-flagged dependency-resolution failure was a separate infra issue. This remains gated on a write-capable maintainer for final approve/merge, not on further changes to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
