DanielLeens commented on PR #11932:
URL: https://github.com/apache/seatunnel/pull/11932#issuecomment-5578502768
@SEZ9 no worries at all on the rendering glitch — appreciate you circling
back to confirm.
To speed up your verification of the two remaining items, here are direct
pointers on the current head (`b6c96b97356d`):
1. **Docs/upgrade note (JDBC sink checkpoint state):**
`docs/en/introduction/configuration/schema-evolution.md:44-54` (and the
`docs/zh` counterpart, same section), under "## Checkpoint restore
compatibility". It states the JDBC Sink records its evolved writer schema after
a schema change, exactly-once sinks keep XA recovery state on every checkpoint,
and explicitly: "A checkpoint written with evolved JDBC writer schema is not
downgrade-compatible with an earlier SeaTunnel release." That's the
forward-compatible-but-not-downgrade-compatible caveat I referenced.
2. **`Collector.restoreSchema` Zeta-only no-op:**
`seatunnel-api/src/main/java/org/apache/seatunnel/api/source/Collector.java:38-48`.
The default method's Javadoc states: "Only the Zeta engine collector restores
this state today. Flink and Spark retain the default no-op implementation until
their translation-layer collectors support schema restoration." The same fact
is repeated in the last line of the docs section above ("Flink and Spark do not
currently restore this collector schema state.").
I re-pulled both files directly from the current head via the API just now
(not relying on my earlier review text) to confirm they match what I described
— both are in place as of `b6c96b97356d`, so from my side both items are
closed. Let me know once you've had a chance to verify on your end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
