Rangsh commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-5618099369
@DanielLeens Thanks for the third-round re-review — glad Issue 2 and the previously flagged `connector-file-local-it` concern are confirmed resolved. Quick CI update on the fork run you were watching ([Rangsh/seatunnel` run 34433792914](https://github.com/Rangsh/seatunnel/actions/runs/34433792914)): - First pass had a few unrelated flakes (`engine-v2-it (11)` = `SinkErrorToMysqlIT` container-thread teardown timeout; plus `doris`/`oracle-cdc`/`kudu`), none of which touch this PR's `TaskExecutionService` rollback path. - After `--failed` re-run, the run is now fully green: **79 success / 14 skipped / 0 failure**. - Confirmed green on the jobs you called out: `connector-file-local-it` (8 & 11), and `engine-v2-it` (8 & 11). On the non-blocking Low item (deterministic `CooperativeTaskWorker` race coverage): agreed it's a nice-to-have; happy to leave it out of this PR's scope unless a maintainer prefers it landed here. Please take another look when convenient. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
