Rangsh commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5642901321
Thanks @SEZ9 — finishing the truncated F6 point (no further code change on this head). **F6 (`JobHistoryServiceFinishedMetricsTest` in `ca82f95`)** — confirmed covered: 1. **Observable contract (not `never().computeIfAbsent`)** — `storeFinishedPipelineMetricsWritesOnceForNewJob` and the merge tests assert a single IMap `put(jobId, …, ttl, MINUTES)` with the merged value, plus explicit `lock(jobId)` / `unlock(jobId)` verification. 2. **Null-metrics path** — `storeFinishedPipelineMetricsRejectsNullMetrics` asserts `NullPointerException` when `metrics == null` (matches `Objects.requireNonNull(metrics, "metrics")` in the method). 3. **TTL-preserving put path** — the new-job / merge / distinct-tag tests all verify `put(..., FINISHED_JOB_EXPIRE_MINUTES, TimeUnit.MINUTES)` (here `1440`), i.e. the configured history TTL is retained on the single write-through put. Happy to wait on your verify pass over `c553a8c04` / `ca82f95` / `9a6077c58`. From our side nothing else remains open from the previous review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
