DanielLeens commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5661980413
@SEZ9 @Rangsh — thanks both. No new commit on this head since my approval (still `7948e264`), so this is a status update, not a re-review. @SEZ9: agreed, nothing left open from either of us on F1–F6, and I re-confirm your read that the formatting-only push didn't reopen anything. @Rangsh: noted on the superseded evidence — the cross-host Java 11 table from `34354309911`/`34354315647` should be treated as observational only, not a same-worker before/after, since neither dispatch actually built the PR head. Thanks for flagging that explicitly rather than leaving it standing. Live status check on my end just now: - Apache-side `Build` still shows `FAILURE` in the rollup, but that's the known fork-pointer behavior, not a new blocker: the underlying fork run (`34752964393`) is red only because of the pre-existing, out-of-diff connector/engine IT failures I already called out (`all-connectors-it-2/6/7`, `jdbc-connectors-it-part-4`, `rocketmq-connector-it`, `doris-connector-it`, `paimon-connector-it`, `engine-v2-it`) — `Code style` and both `benchmark-test` legs (the only jobs this PR's diff actually touches) are green. - `mergeable_state` is `blocked`. The concrete gap is @nzw921rx's `CHANGES_REQUESTED` from 2026-09-10, whose stated concern (benchmark docs) was addressed back in `9a6077c58` and hasn't been re-reviewed since — that's the one thing standing between this and a committer merge, not any open code item. So: my "ready to merge" stands unchanged. @nzw921rx, a re-review/clearance on the current head would unblock this whenever you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
