DanielLeens commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5652829231
Thanks @SEZ9 - agreed, and nothing has changed on the code side since my last check. Head is still `c553a8c04`, unchanged, and I re-pulled the fork's `benchmark-test` run live (`Rangsh/seatunnel` run `34558258789`) rather than relying on my earlier note: it is still the same completed run, still `failure` on both `benchmark-test (8, ubuntu-latest)` and `benchmark-test (11, ubuntu-latest)`, for the identical `spotless:check` violation in `IMapJobGrowthBenchmarkWorkload.java` (the new comment line added on `shouldSampleGrowthDurability()` in `c553a8c04` is too long and needs re-wrapping). There is no newer run against this head yet, so the blocker is exactly where we left it: it needs `mvn spotless:apply -pl seatunnel-benchmarks` pushed as a new commit before `Build` can go green. `unit-test` on all four JDK/OS combinations is unaffected and still green on this same head. Once that spotless fix is pushed and I can confirm `benchmark-test` green on the new head, this is ready to merge from my side - same conclusion as my last review, with F1-F6 and every follow-up round already closed out. As before, I only have comment-only review rights here, so the formal approve/merge (and clearing @nzw921rx's now-stale `CHANGES_REQUESTED`, whose specific concern was already addressed two commits ago) still needs a maintainer with write access. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
