DanielLeens commented on PR #11545: URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-5645106157
Fair ask — links below, and I re-pulled each file at the current head (`fbd46ce70df3`) just now to confirm the line numbers still match rather than trusting my own earlier comment. **Commit diffs:** - F1/F5: https://github.com/DanielLeens/seatunnel/commit/504eb8b29791cf0c9d0efb1c27c54dc85444e9d4 - F2: https://github.com/DanielLeens/seatunnel/commit/1b1da9e864e8f51a12ae535aa1dc73ac90ade04c - F4/F7: https://github.com/DanielLeens/seatunnel/commit/be5492399ba3f8e94f489e45454173291aa37627 **F1/F5, client launcher:** you're right that my checklist only cited `seatunnel-cluster.sh`, but `504eb8b2979` touches both scripts. `seatunnel.sh:112-118` has the same Java-11 pre-flight check (`Error: SeaTunnel requires Java 11 or newer, but Java ${JAVA_MAJOR_VERSION} was detected...`), and `seatunnel.sh:120-136` appends the same six module flags with the same dedup-against-existing-JAVA_OPTS logic as the cluster launcher. So the client path isn't missing the fix, I just described it incompletely. **F2:** confirmed at current head — `KuduUtil.java:154-161` and `PaimonSecurityContext.java:144-151` both catch `IllegalAccessException` and `log.error` the specific missing `--add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED` flag rather than swallowing it. **F4/F7:** confirmed — `upgrade_compatibility.yml:60` pins `java-version: "11"` for the job, so the old 2.3.13 release no longer runs under JDK 17. **F3, F6, F8 — still open, no new commits today.** Since this pass is about answering your questions rather than pushing code, here's where each stands so we're not re-litigating scope when the fixes do land: - F3: trim `config/jvm_*_options` to only the flags each consumer actually needs, with a per-flag comment naming the consumer (Hazelcast for the `java.base` opens, Kerberos reload for the `jgss` export), rather than the current blanket set applied to every node. - F6/F8: drop or scope the workflow-level `JAVA_TOOL_OPTIONS` in `backend.yml` now that the launchers inject the flags themselves, so CI doesn't mask a packaging gap and child processes stop printing the `Picked up JAVA_TOOL_OPTIONS` noise. I'll push actual commits for F3/F6/F8 rather than another status update, then ping you for the rebase-and-final-pass we agreed on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
