DanielLeens commented on PR #11545: URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-5645188285
Here are the diffs for the three commits, on this PR's own commit view so they can be reviewed in place: - `504eb8b2979` (F1 / F5): https://github.com/apache/seatunnel/pull/11545/commits/504eb8b29791cf0c9d0efb1c27c54dc85444e9d4 touches only `seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-cluster.sh` (+26) and `seatunnel-core/seatunnel-starter/src/main/bin/seatunnel.sh` (+26). The client-launcher block you asked about is [`seatunnel.sh` L112-L131 at `fbd46ce70df3`](https://github.com/apache/seatunnel/blob/fbd46ce70df3/seatunnel-core/seatunnel-starter/src/main/bin/seatunnel.sh#L112-L131): the Java-version pre-check is L112-L118 (`Error: SeaTunnel requires Java 11 or newer, but Java ${JAVA_MAJOR_VERSION} was detected...`) and the six-flag injection loop, deduplicated against whatever `config/jvm_client_options` already contains, is L120-L131. It is the same block as [`seatunnel-cluster.sh` L157-L176](https://github.com/apache/seatunnel/blob/fbd46ce70df3/seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-cluster.sh#L157-L176). - `1b1da9e864e` (F2): https://github.com/apache/seatunnel/pull/11545/commits/1b1da9e864e8f51a12ae535aa1dc73ac90ade04c touches `connector-kudu/.../KuduUtil.java` (+11) and `connector-paimon/.../PaimonSecurityContext.java` (+11); each adds a separate `IllegalAccessException` catch that logs the missing `--add-opens` / `--add-exports` flag at error level instead of falling into the generic swallow. - `be5492399ba` (F4 / F7): https://github.com/apache/seatunnel/pull/11545/commits/be5492399ba3f8e94f489e45454173291aa37627 touches `.github/workflows/upgrade_compatibility.yml` (+5/-1), pinning `java-version: "11"` for the whole job so the old 2.3.13 release never runs under JDK 17. F3 / F6 / F8 remain open, as in the checklist. I will push them as commits on this branch rather than another status note: - F3: a per-flag comment in `config/jvm_master_options`, `jvm_worker_options`, `jvm_client_options` and `jvm_options` naming the consumer of each `--add-opens` / `--add-exports`, and removal of any flag that no consumer actually needs. - F6 / F8: remove the workflow-level `JAVA_TOOL_OPTIONS` from `.github/workflows/backend.yml` and scope the module flags to only the jobs that run Hazelcast or the Kerberos reflective reload inside the test JVM itself. The launcher injection already covers the containerized clusters, and this removes the `Picked up JAVA_TOOL_OPTIONS` noise from every child process. I will ping here once the head is updated and the fork Build is green on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
