SEPURI-SAI-KRISHNA commented on PR #12182: URL: https://github.com/apache/seatunnel/pull/12182#issuecomment-5651054691
Thanks @DanielLeens. Rather than resolve the conflict, I have rebased this onto current `dev` and dropped the fix, since #12215 landed the same two branches first. What is left is only the coverage #12215 did not include, which is the three gaps you identified when you compared the two PRs. The planner-side assertion, so `typeMapping()` declaring `BYTE_TYPE` and `SHORT_TYPE` is checked against `transformBySQL` returning exactly those runtime types. The original defect was a disagreement between those two halves, and a value-only test passes even if the planner half regresses. The `Byte.MIN_VALUE` and `Short.MIN_VALUE` divisor cases, which are the inputs that would fail first if the reasoning behind the absent range check were wrong. That reasoning written down at the call site, so the next reader does not add a guard that cannot fire. The title and description are updated to match. Both tests fail against `dev` with #12215's two branches removed and pass with them, and the full module is green at 1149 tests. No objection at all to #12215 having gone first. The fix was the same in both, and this is the part worth keeping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
