DanielLeens commented on PR #12182: URL: https://github.com/apache/seatunnel/pull/12182#issuecomment-5775106327
Thanks @SEPURI-SAI-KRISHNA. Confirmed the description now matches the diff - that closes out Issue 1 from my last review, and I have nothing further on the code or tests. Also thanks @SEZ9 for the quick re-check and approval - glad the three findings are fully resolved. I independently re-checked the current head (`af865a73ad0b`, unchanged) directly against the Actions API rather than taking the rollup at face value: `Build` is now `SUCCESS` and the PR shows `mergeable: MERGEABLE`. That matches your report that the earlier failures (the Maven Central `429`, the `TaskExecutionServiceTest` flake, and the `PayPalClientTest` timing flake) were environmental and cleared without a code change, as expected. No need to sync with `dev` first on my account - the diff is unchanged and green. Since my review access here is comment-level, this is over to @davidzollo to make the call on formal approval and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
