luozihen commented on PR #12015: URL: https://github.com/apache/seatunnel/pull/12015#issuecomment-5658593905
@DanielLeens Thanks for independently verifying F1 and for pinning down the merge semantics precisely. Agreed — the change is a narrowing from HOCON-style recursive `withFallback` to a shallow top-level merge, and your call-site analysis matches mine: no current caller can hit the diverging case. I've added a Javadoc note on `mergeOptions()` stating that the merge is shallow/top-level and that, on a key collision, `primary` replaces `fallback`'s value wholesale rather than recursively merging nested objects. Thanks for the suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
