SEZ9 commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5690954971
@Rangsh thanks for the ping. On the docs point (F4): noted that `9a6077c58` removed the `runningJobGrowth` / `completedJobHistoryGrowth` growth-scenario notes from `docs/en` and `docs/zh`, which is what that finding was about. I'll re-check it on the current head `7948e2640`; no further push needed for that item. Before I finish re-reviewing, a short status line on `7948e2640` for the other earlier findings would save me re-auditing from scratch: - F1/F3 (`IMapJobGrowthBenchmarkWorkload`): is the evict+loadAll durability sample still once-per-fork on the last key only, or was it widened / moved back per-iteration? If unchanged by design, a one-liner on why is fine. - F2/F5 (`storeFinishedPipelineMetrics`): was the Javadoc "in memory" wording tightened, and is the non-atomic get/merge/put still intentionally relying on the per-JobMaster lock? - F6 (`JobHistoryServiceFinishedMetricsTest`): were the null-metrics / TTL-preserving paths covered, or is that deferred? Just note the answers here and I'll re-check against the head and close out accordingly. <!-- streview-comment:1074 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
