DanielLeens commented on PR #10502: URL: https://github.com/apache/seatunnel/pull/10502#issuecomment-5713060506
Hi @CloverDew, just a heads up: GitHub auto-marked this PR as stale after 120 days of inactivity, and it will close in 7 days without further activity. Separately, I checked the current state on the latest head (915fe2f) and GitHub now reports a real merge conflict against `dev` (`mergeable: false`, `mergeable_state: dirty`), most likely from drift on `dev` since this branch was last synced. If you want to keep this moving, you will need to sync with the latest `dev` and resolve the conflict before further review makes sense. To recap where things stand from my side: the remaining blocking item is still the missing `docs/en` / `docs/zh` coverage for the new `dirty.collector` / `dirty.validator` config and SPI extension points (see my May 17-18 comments). The API compatibility, cross-engine fail-fast consistency, and collector lifecycle issues I flagged earlier are already fixed on this head. No need to rush purely because of the stale bot, but if you do come back to this, syncing with `dev` first will make it much easier to verify the diff is still clean. Happy to help scope the docs down to something minimal to start if that is the main blocker for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
