SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5754746735
Thanks for the follow-up commit `416e8cd9d`. A few notes at this head (`416e8cd9d28f10fd976ebaaea5a4b1cea5ac73c4`): - I haven't been able to verify the earlier points against the diff myself (E2E wait strategy in `FakeSourceToConsoleWithEventReportIT`, `close()` hardening in `JobEventHttpReportHandler`, the Kotlin stdlib split in `known-dependencies.txt` / release-docs `LICENSE`, the unbounded `takeRequest()` waits in `JobEventHttpReportHandlerTest`, redirect following, and the Content-Type charset behaviour), so I'm not marking them resolved yet. Could you point to the commits that address each, or summarise the changes in the PR description? For the Content-Type charset point in particular, please confirm whether the reported header stays byte-identical for existing collectors — I don't see that recorded in the thread. - CI: the `Build` check for this head and fork run `35491433934` are still `queued`, so there is no CI result for this head yet. At `5cde0fdd8` (fork run `35045349301`), `Dependency licenses`, `Code style` and `engine-v2-it (11, ubuntu-latest)` were green, while `engine-v2-it (8, ubuntu-latest)` stopped in an unrelated module before reaching the console E2E. Once the run for this head finishes, it would be good to have a Java 8 run that actually executes `FakeSourceToConsoleWithEventReportIT` and `HttpReportPackagingIT`. - There is still an open CHANGES_REQUESTED review on the PR, so I'll hold off on a final call until that is addressed and CI reports for this head. <!-- streview-comment:1204 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
