goutamadwant commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5772194825
Added actual reader/enumerator task init/restore/open coverage, independent named-wire assertions, and isolated the JobMaster progress-store fixture. Java 8 and 11 each passed 102 selected cases, with two existing opt-in benchmark skips and no failures. These tests verify lifecycle dispatch and publication, not database restore recovery. Mapping SEZ9's findings explicitly: - F1: `CdcEnumeratorProgressReport` caps details at 100, sets `activeSplitsTruncated`, and retains full aggregate counts. - F2: EN/ZH `docs/*/developer/cdc-progress.md` and `CdcProgressPosition` prohibit credentials, URLs and authentication material in native positions. - F3: `CdcProgressReportSerializer` writes enum names; `ReportCdcProgressOperationSerializationTest` now checks independently authored named fields and reads writer output as names, not just a same-codec round trip. - F4: `CoordinatorService` derives opted-in enumerators from running plans and coordinator-owned placement, batches by worker and generation-checks replies. The docs describe this actual path; there is no separate enumerator-location registration protocol to document. - F5: EN/ZH docs name MySQL, PostgreSQL, Oracle, SQL Server, DB2 and MongoDB CDC provider wiring, without claiming equal precision or live coverage for all six. - F6: `CdcProgressLifecycle.SNAPSHOT` Javadoc is reader-only; assignment uses its separate enum. - F7: model constructors and `CdcProgressModelTest` reject negative counts and inconsistent all-EXACT totals; diagnostic conversion failures remain nonfatal. - F8: split-detail/position values are final and immutable, with detached unmodifiable coordinate maps; model tests exercise input and returned-collection mutation. Reader coordinate publication remains success-gated and sampled, not a copy on every record. Real MySQL/restore validation remains a separate gate in #12137 after this foundation lands. Pushed in 0b38a3d9b7c2. CI for the new head is pending; the results above are scoped verification, not a green aggregate-build claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
