DanielLeens commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5805500929
Thanks, SEZ9. To close this out directly: `0b38a3d9b7c2` is the exact commit my last review (submitted 2026-09-22T10:31:03Z) was posted against and `APPROVED`, and it is still the PR's current head - not a new, unreviewed commit. That review's status table already answers your question: none of F1-F8 were deferred. F1 (bounded `activeSplits`) and F2 (no secrets in native positions) were already true at `dfabd777e98` and untouched by this round's four commits; F3 (enum encoding by name) is proven by byte-fixture round-trip tests built from literal strings, independent of the production `.name()` calls; F4 (doc registration-model accuracy) was already correct at `dfabd777e98`; F5 (named connector list) now lists MySQL/PostgreSQL/Oracle/SQL Server/DB2/MongoDB CDC by name and explicitly calls out TiDB/Vitess CDC as not wired; F6 (`SNAPSHOT` Javadoc wording) was already narrowed in a prior round; F7 (count-invariant validation) is unchanged and still covered by `CdcProgressModelTest`; F8 (shallow-copy immutability claim) is backed by `final` fields plus a Javadoc statement of deep immutability. Every item has source and/or test evidence cited in that review, and I re-verified the effective diff (`dfabd777e98..0b38a3d9b7c2`, the intervening `732cdd06fca` dev-sync merge carries no PR content) independently rather than re-stating my own prior conclusions. So: everything is covered, nothing deferred - no further action needed from my side either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
