SEZ9 commented on PR #12454: URL: https://github.com/apache/seatunnel/pull/12454#issuecomment-5806187860
@DanielLeens, addressed the review in `1ce4248c7ecb` and rebased onto current `dev`. Please take another look. - **Issues 1–2:** removed the worker-loss/cancel fix, its test and documentation, and the backpressure fixture changes. #12311 and #12313 remain the authoritative PRs for those changes. The description explicitly identifies the production checkpoint-lock starvation fix as separate work in #12316. - **Issue 3:** removed the historical extraction wording. The description now explains the final scope and the related PRs. The timeout changes are already merged through #12445, so this PR now has no workflow diff. - **Issue 4:** replaced the new private-field reflection with `@VisibleForTesting runWhenNoCheckpointPending`. The pending-state check and fault injection still execute together under the coordinator lock, without exposing the lock or counter to the test. - **Issue 5:** kept the standard ASF file header and moved the Debezium copyright/origin attribution into the existing class Javadocs. - **Issue 6:** replaced the private-method-name stack check with an executor-submission latch and an unfinished-deployment wait-state check. The early-failure/cancellation assertions are unchanged. Local validation on OpenJDK 11: full-root Spotless and `-DskipTests verify` passed; 45 engine regression cases, the real checkpoint dispatch-failure integration case, and 32 PostgreSQL/PayPal cases all passed (78 total, no failures, errors, or skips). The updated diff is 20 files. CI has been triggered for the new head; its result is still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
