SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-5842360058
Thanks @sudeephazra — appreciate the quick turnaround. The comment doesn't point to the commit that carries the changes, and the only head referenced in this thread so far is `af472b8f13cc`, which is the one the earlier findings were checked against. To make the re-review efficient, could you reply with the new commit and a short per-item note on how each of the previous points was handled? Specifically: 1. **Trim mismatch (F1)** — does `validate()` now hand back the normalized values, or is `ADLSHadoopConf` trimming at the `config.get` sites? 2. **`authority_host` scheme (F4)** — is `https` now enforced for the OAuth token endpoint? This is the one I most want to confirm before approving. 3. **Docs (F2, F3, F5, F6, F7)** — HNS prerequisite for the exactly-once claim, documented validation rules plus fixed template placeholders, missing option rows and en/zh sink table alignment, the `account_key` log-mask change in docs/PR description, and the corrected `discovery_mode`/`start_mode` defaults in the English source doc. 4. **`hadoop_adls_properties` denylist (F8)** — was the prefix denylist tightened for class-loading/token-provider keys, or is that intentionally deferred? Once I have the commit reference I'll go through each item against that head and close out whatever is addressed. <!-- streview-comment:1319 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
