DanielLeens commented on PR #10808: URL: https://github.com/apache/seatunnel/pull/10808#issuecomment-5846254979
Thanks for flagging that, @SEZ9 — I just re-pulled both files directly from `0d4d8624c` to double-check, since I'd rather hand you fresh line numbers than assume the earlier comment rendered correctly on your end. **F5** is there and unchanged. In `docs/en/engines/zeta/rest-api-v1.md`, right after the `nodeRole`/`coordinator`/`worker` field descriptions, the doc reads: "`nodeRole`, `coordinator`, and `worker` disclose the cluster topology. The REST API V1 has no authentication, so restrict network access to it when this information is sensitive." That's the full sentence — nothing was truncated in the source itself, so whatever you saw cut off was most likely a rendering hiccup on the GitHub comment, not a gap in the PR. **F8** is also there — apologies, my earlier note just gave the bare filename without the package path, which is probably why it didn't show up when you went looking. The file is `seatunnel-core/seatunnel-starter/src/test/java/org/apache/seatunnel/core/starter/seatunnel/command/ServerExecuteCommandTest.java`. Line 37 has `import java.util.Collections;`, and the two call sites are `Collections.singletonList(...)` at lines 114 and 177 (correcting my earlier "39/102" reference, which was off — 114/177 is what's actually in the current diff). No inline `java.util.Collections` FQN remains anywhere in the file. So F1-F8 all still check out against `0d4d8624c` from my side. The only thing left blocking merge is unchanged from my last comment: `mergeStateStatus` is still `DIRTY` and `Build` is still `FAILURE` on this head. Once @davidzollo syncs with the latest `dev`, resolves the conflict, and we get a green run on the synced head, this is ready to merge on the source-review side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
