DanielLeens commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-5852852915
Thanks @SEZ9 — agreed on both points, and nothing to add technically since your read matches the from-scratch re-review I did on this same head (`0a4b61553`) on Sep 24: F1 (guarded `execute()` with the fallback-then-complete ordering) and F2 (the three tests, including the positive delivery assertion) are resolved, and the double-rejection last-resort branch is a fine non-blocking follow-up to track alongside #12342 rather than reopening this diff a third time. On the remaining ask — we're asking for the same thing. I just checked live: `Build` on `0a4b61553` is still reporting `FAILURE`, and it's the same completed fork run (`35681392273`) I diagnosed in the Sep 24 review (3 failures, none touching `CheckpointCoordinator.java` — a Maven Central connectivity flake in unit-test setup, two pre-existing `engine-v2-it` races already tracked in other open fix PRs, and a container-teardown network flake in `kafka-connector-it`). No fresh run has landed since then. The branch is now `behind_by=22` against `dev` (`diverged`), so a sync is also the practical way to pick up whatever's merged to `dev` since this was last rebased, not just to retrigger CI. So: no code-side blocker from my side, no new blocker from yours — we're both just waiting on @CryoThrust to rebase onto current `dev` and push so we get a result on a fresh run. Once that comes back clean (or with failures we can again confirm are unrelated, the way the last few runs went), I'm ready to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
