SEPURI-SAI-KRISHNA commented on PR #12438: URL: https://github.com/apache/seatunnel/pull/12438#issuecomment-5852890690
Correcting my comment above. I wrote that "merging #12381 first fixes this for everyone and this PR goes green on its own". That is wrong, and I would rather say so than leave a bad pointer on a PR waiting for a merge decision. #12381 widens the arrival wait from 15s to 60s. But the failure is not a wait that runs out, it is a latch that never fires. @SEZ9 traced it on that thread and @DanielLeens confirmed it against the source: `PayPalClient.execute()` returns on a transient status without reading the entity, then aborts the request in its `finally`, while the test server only calls `arrived.countDown()` after `exchange.getResponseBody().write(...)` succeeds, inside a `catch (IOException ignored)`. `closeWakesRetryWait` replies with a plain 503, so it takes exactly that path: if the abort wins the race the write throws, the exception is swallowed, and nothing ever counts the latch down. No budget fixes that. @goutamadwant then measured it, 50 runs per variant: | variant | normal | with the body write forced to throw | |---|---|---| | dev | 5 of 50 fail | | | #12381 | 1 of 50 fail, after the full 60s | 20 of 20 fail | | #12444 | 0 of 50 | 0 of 20 | So the PR that actually clears this red leg is **#12444**, not #12381. It releases the latch before the body write and adds a `finally` safety net, which is the root cause rather than a wider ceiling. #12381 is now marked changes-requested. Nothing on this PR changes: still two comment lines, still byte-identical to `dev` once comments are stripped, still no code path to `connector-http-paypal`. The options are the same as before, only the first one now names the right PR: merge #12444 first and this goes green, or take this with the known-unrelated red leg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
