SEPURI-SAI-KRISHNA commented on PR #12438: URL: https://github.com/apache/seatunnel/pull/12438#issuecomment-5904594131
Thanks @SEZ9. Re-posting the clipped paragraph in full, and it is now out of date in the best way, so here is the current state instead of just the text you were missing. What the clipped paragraph said: the run that was red on this head was void rather than failing. `Code style` died at 4m58s before Spotless ever ran, because the Maven wrapper jar download from `repo.maven.apache.org` returned HTTP 429 on five consecutive retries and the job ended in `Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain`. That gated 52 downstream jobs. I said I was rerunning it and that `spotless:check` was clean locally on both modules. That rerun has since finished and it is green. Attempt 2 of run `36437331456` on unchanged head `5cc724b9342` completed at 03:19:06 UTC on September 29 with conclusion `success`: 28 jobs successful, 40 skipped, 0 failed. The upstream `Build` check on this PR is passing, alongside `labeler` and `Notify test workflow`. So all three checks are green and there is no red badge left to explain. Nothing changed in the diff to get there. The head is still `5cc724b9342`, the blobs are still `03ecf079` for `RocketMqAdminUtil.java` and `7fc989a0` for `RocketMqIT.java`, and attempt 2 was a rerun of the same commit rather than a new push. So the diff you are about to read at `5cc724b9342` is the one that produced this green run. On your two findings, reading them at the current head is the right call and I am not asking you to take my quotes for it. Two greps that may save you a pass: For PR12438-F1, the string "unreachable" appears zero times in `RocketMqAdminUtil.java` at this head. The word "reachable" appears exactly once, at line 350, inside "The invariant does not cover one transition, and that transition is reachable today", which asserts the transition is reachable rather than denying it. For PR12438-F2, `RocketMqIT.java` at this head contains zero matches for `#[0-9][0-9][0-9][0-9]`, so no PR number anywhere in the file, and the comment at lines 535-540 has no past-tense narration of the previous code. One caveat so the grep does not surprise you: line 604 does say "previously had", but that is a pre-existing comment about the topic's queue count, it is on `dev` unchanged at line 603, and it is outside this diff. Nothing else outstanding from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
