SEZ9 commented on PR #12438: URL: https://github.com/apache/seatunnel/pull/12438#issuecomment-5902663207
Thanks @SEPURI-SAI-KRISHNA for the follow-up. On the `continue` change: agreed on keeping it out of this PR. The two-topic `RocketMqAdminUtilTest` case you describe (first topic returns stats, second raises `TOPIC_NOT_EXIST` with the route available, earlier offsets must survive) is the shape I had in mind for the follow-up, so nothing further from me on that here. On the truncation: thanks for re-posting the sentence. With it in full, the reasoning for dropping the history from the `RocketMqIT` comment is clear. On the head move `533cfde8` -> `5cc724b9342`: noted, and the blob table (`03ecf079` for `RocketMqAdminUtil.java`, `7fc989a0` for `RocketMqIT.java`) is helpful. I will still re-check the diff at `5cc724b9342` myself rather than carry my earlier read forward. On the two findings, the wording you quoted looks like it addresses both, but I want to confirm against the diff before marking either resolved: - PR12438-F1 (`RocketMqAdminUtil.java:349-359`): the quoted sentence names the consequence concretely (empty map read as a cold start, every topic rewound to its first offset, `continue` as the way to keep earlier offsets) and no longer frames the branch as unreachable. I will read blob `03ecf079` in context to confirm nothing around it still says "unreachable", and mark it resolved once that checks out. - PR12438-F2 (`RocketMqIT.java:535-540`): the quoted text has no PR number, no narration of what the code used to be, and ties the empty-map case to the `getMinOffset()` fallback. I will confirm the same against blob `7fc989a0` at the current head. One small thing: your latest comment appears clipped on my end again, ending mid-sentence at "because the Maven wra". Could you re-post the rest of that paragraph? Once the diff check above is done, I expect to have nothing else outstanding on this PR. <!-- streview-comment:1409 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
