SEZ9 commented on issue #12617: URL: https://github.com/apache/seatunnel/issues/12617#issuecomment-5976037253
Confirmed on dev: all eleven call sites exist at the cited lines (VectorReduceFunction:60, BuiltinFunctions:54, ModalityType:60/78/102, PayloadFormat:40, DoubaoModel:388, ModelInvocationCacheKey:144, AbstractModel:123, DataValidatorTransformConfig:168/336). Switching each to toUpperCase(Locale.ROOT)/toLowerCase(Locale.ROOT) matches what #12495 did for the sql subtree. Please also add the tr-TR unit tests described so the regressions are guarded. Please open the PR as a follow-up to #12495 and consider adding a forbidden-apis / checkstyle rule (or a regex check in CI) against bare toUpperCase()/toLowerCase() in seatunnel-transforms-v2 so new sites do not reappear. Note: FieldRenameTransform:167/170 and TableRenameTransform:153/155 also use bare case conversion, but those apply user-requested renames to data rather than matching tokens, so changing them could be a behavior change for users on non-ROOT locales. Suggest keeping them out of scope for this fix and discussing separately if needed. <!-- streview-comment:1505 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
