SEPURI-SAI-KRISHNA commented on issue #12617: URL: https://github.com/apache/seatunnel/issues/12617#issuecomment-5988593655
Thanks @SEZ9. Taking the three in order, and two of them were already in flight before your comment, so apologies if the pointers were easy to miss. **(c) Tracking issue: already open as #12620**, with the scope you list. It enumerates the baseline (24 bare sites on `dev` `af80a6704`: 13 in `sql/` covered by #12495, 11 by #12618, so the two together take the module to zero), keeps the guard out of #12618, and holds off on a Checkstyle or forbidden-apis dependency until the scope is agreed. You have since commented there and acknowledged the `FieldRenameTransform` / `TableRenameTransform` correction, so this is just a cross-link for the record. **(b) Hardening-vs-reachable note: added to the #12618 description.** The split is five reachable and six hardening. Reachable are `ModalityType:60/78/102`, `PayloadFormat:40` and `ModelInvocationCacheKey:144`, where the compared literal contains an ASCII `i`. The other six, including `BuiltinFunctions:54`, are consistency changes: I checked all twelve shipped Calcite UDF names and none is altered by a Turkish `toUpperCase`. The four added tests cover the reachable group. **(a) #12618 Build: unrelated to the change.** I posted the full triage on the PR yesterday; summarising since it is easy to miss. Head is unchanged at `48599a8f6` and all three failures in run `37140738764` are already-tracked issues: `transform-v2-it-part-1 (11)` is `TestFilterRowKindIT.testFilterRowKindMultiTable` (#12116), `engine-v2-it (11)` is `BackpressureSlowSinkIT` (#12313 / #12316), and `paimon-connector-it (8)` is `PaimonWithS3IT.privilegeEnabledPaimonSourceUnAuthorized` (#11679). I first took those for timeouts because the jobs ran 97, 90 and 60 minutes, and that was wrong: `backend.yml` sets 135, 150 and 180 for them, so they are real failures of known-flaky tests. #12116 names the exact test and config and says it reproduces only on the Flink legs, which is the leg that failed. Every `src/main` change in the PR is `X.toUpperCase()` to `X.toUpperCase(Locale.ROOT)` or the `toLowerCase` equivalent plus the import, so on a non-Turkish runner the diff is a runtime no-op and cannot affect a row count, a checkpoint or an S3 privilege check. Happy to rerun the three jobs if you would rather see the aggregate green, though #12116 will keep recurring on the Flink leg until it is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
