li3zhi4 commented on PR #11746:
URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-6073708129

   @SEZ9 @nzw921rx — the latest CI exposed a real issue in my previous 
follow-up, not an unrelated flake: 
`JdbcMysqlSplitIT.testCompositeKeyWithStringColumn` still required multiple 
composite chunks after I changed STRING-containing primary keys to the 
single-column fallback. Both JDKs failed that assertion. I have corrected this 
in `6d1926d26` and synced current dev; the pushed head is now `832b3b8a5` (dev 
base `3556e91cc9`).
   
   The official MySQL regression now explicitly checks the fallback rather than 
weakening the old assertion: every generated split uses scalar `order_id` / 
LONG boundaries, not a composite tuple; all 300 expected keys are read exactly 
once. The fixture contains mixed-case, accented, non-ASCII and comma-containing 
strings with `utf8mb4_general_ci`, and asserts an actual database-vs-Java 
ordering disagreement (`Z` versus `a`). The separate numeric composite test 
still requires multiple tuple chunks.
   
   Verification on the final merged head: `CompositeKeyChunkSplitterTest` 
20/20; full official `JdbcMysqlSplitIT` 7/7, failures 0, errors 0, skips 0; 
connector and E2E Spotless pass; diff check clean. The official 
Failsafe/Testcontainers run uses a real MySQL container. Docs now explicitly 
state that even binary-collation STRING components use the fallback; there is 
no currently available opt-in.
   
   The dev sync also includes the upstream DeepWiki429 exception (#12639), 
digest-pinned MinIO replacement (#12297), and the Windows fixture fix (#12394), 
rather than labeling the previous registry failures as flakes.
   
   One separate gate remains: GitHub recorded the new push, but the fork has 
not created a Build run/check suite for the new SHA despite Actions being 
enabled and the Build workflow matching upstream. The upstream check is 
consequently `ACTION_REQUIRED` / workflow-run detection failed. We are not 
claiming CI green. Please help with the normal approval/review assignment and 
Build gate once dispatch is available; dev requires a current approving review 
and successful Build before merge-queue admission.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to