CodeWithPravinMaske commented on PR #12597: URL: https://github.com/apache/seatunnel/pull/12597#issuecomment-6129077944
Thanks @DanielLeens for the re-review! 1. **Oracle / PostgreSQL docs**: added the same NOT NULL sentence to the "unique non-primary column via `table-names-config.primaryKeys`" recipe in `Oracle-CDC.md` and `PostgreSQL-CDC.md` (en and zh). DB2, SQL Server and openGauss don't have that recipe. 2. **Metadata query for real-PK tables**: I'd keep it as is for now. It's one `getColumns` call per table at split generation, next to the per-table metadata and min/max queries that `getSplitColumn` already runs, and a dialect with a cheaper source can override `isColumnNullable`. Happy to fetch the columns once per table in a follow-up if startup time on very large table lists becomes a concern. 3. **Inline logger**: an interface can't hold a private logger field, and a `Logger` constant would become a public field of the dialect SPI. So I left the lookup inline. It only runs on the rare metadata-miss path, right before falling back to the parsed column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
