SEZ9 commented on PR #12608: URL: https://github.com/apache/seatunnel/pull/12608#issuecomment-6159374908
Thanks for the summary, @CodeWithPravinMaske. To close out the earlier points I need to verify them against the diff rather than the description, so a few pointers would help: - Removal of `restoreNullableColumns` and the move into the `MySqlAntlrDdlParser` override (binlog DDL via `parseStreamingDdl` and checkpointed history): which commit(s) carry this? Is there a test that exercises the streaming-DDL path and asserts the column stays nullable? If one exists, the test method name is enough. - Docs and the `incompatible-changes.md` note (en/zh): a pointer to the changed files would help. - Nullable `table-names-config.primaryKeys` column emitting NULL: I'll check `MySqlSchemaTest#testNullableColumnConfiguredAsPrimaryKeyEmitsNull` once I can see the diff. I'll re-review the new head once `dev` is merged in; please ping me then. <!-- streview-comment:1729 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
