88fantasy commented on PR #12208: URL: https://github.com/apache/seatunnel/pull/12208#issuecomment-6336846242
Thanks @DanielLeens and @SEZ9 for the follow-up. I have merged `dev@99ea16b9d` without conflicts and pushed the updated head `05422f37c`. Both remaining wording comments are addressed: - The PR description now correctly attributes token rejection coverage to `LineageConfigTest#rejectsTokenInJobOptions`, rather than `EnvOptionRuleTest`. - The option description, rule comment, and English/Chinese documentation now explain that job-level tokens are rejected when `LineageConfig.resolve` runs. They also state that engine integrations must validate before persisting or serializing job configuration, including when lineage reporting is disabled. This follow-up changes wording only; lineage runtime behavior, configuration keys, and defaults remain unchanged. Submission-path validation and the corresponding engine-level regression tests remain part of #12209 and #12210. Local validation after the merge, using JDK 11: - `./mvnw spotless:apply` — passed. - Full-reactor `./mvnw -q -DskipTests verify` — passed. - 18 targeted configuration, option-sync, option-rule, and Markdown checks — passed, with no failures or skips. CI on the new head is still pending; these local results do not establish CI success. A committer approval is also still required. Please take another look at the wording updates when you have a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
