88fantasy commented on PR #12208: URL: https://github.com/apache/seatunnel/pull/12208#issuecomment-6438304132
Thanks @DanielLeens for the review. I have addressed the two suggestions in `b8d0d1269`: - `LineageRuntime` and `OpenLineageBackend` now rethrow `VirtualMachineError` before handling other failures. Tests cover propagation during backend resolution, rendering and sending, as well as containment of `NoClassDefFoundError`. - The English and Chinese documentation now describe the general JDBC `base-url` fallback. Tests also cover a three-part `table-names` entry and precedence when both `table_list` and `table-names` are present. The branch was subsequently synced with `dev@c875a87bd`; the current PR head is `fb4fd89f`. The merge did not change the lineage modules or the English and Chinese lineage documentation. Local validation on `b8d0d1269` with JDK 11 passed: Spotless, full-reactor `-DskipTests verify`, and 31 focused unit and Markdown tests, with no failures or skips. These results were obtained **before** the subsequent `dev` merge and are not claimed as validation of the exact current head. The exact-head [fork Build](https://github.com/88fantasy/seatunnel/actions/runs/40477948026) is still queued/in progress. Some jobs have passed, but the overall CI result is not yet available. GitHub currently reports the PR as mergeable and requiring review. Could you please take another look when convenient? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
