SEZ9 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6392332415
Thanks for the update, @karthik-0306. On #12858: the one thing still outstanding from the last review round was its Build result. Please go ahead with the re-run of the `BackpressureSlowSinkIT` job you mentioned and post here once the Build has completed; until it lands, the ask stands to hold off on expanding the launcher scope. Nothing else is open on that PR from my side — the ownership note in the module docstring / parameter docs plus the idempotence, re-enable and mocked script-call tests cover what was requested. On the proposal: delivering the remaining pieces one small PR at a time, each only after the previous one lands, is exactly the right cadence. Step 1 (a per-user, per-version cache directory outside `site-packages`) also fits the ownership boundary we settled on for the install-plugin helper: everything that rewrites `config/plugin_config` or anything else under the distribution must keep operating on that caller-managed cache copy only, never a checkout or shared installation. Please keep that constraint explicit in the step 1 PR as well. For the three design questions (gpg CLI vs dependency, the override variable name, and the first target version), I'd rather settle them in the PR that introduces each step than pre-decide them here, so they can be judged against the actual code. Open the step 1 PR once #12858 has landed and raise them there, one at a time. Concrete asks right now: 1. Re-run the flaky job and report the #12858 Build result here. 2. Do not open the step 1 PR until #12858 has merged. 3. Carry the per-user/per-version, caller-owned-copy wording into the step 1 PR description and module docs. <!-- streview-comment:2009 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
