SEZ9 commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6537575749
Thanks @wgzhao — yes, I'll take the formal recheck of F1-F8 against
`4cfc9b02b`. Here's where it stands right now and what I still need before I
can sign it off:
**What I can confirm from your pointers**
- F1 / F3 (`found: false` docs): your `rest-api-v1.md` and `rest-api-v2.md`
line pointers cover all four endpoints (v1 `job-info`, v1 `running-job`, v2
deprecated `running-job`, v2 `job-info`) plus the ZH mirrors, which is exactly
the gap those two findings described. I'll verify the rendered JSON examples
match what `JobInfoService` actually emits.
- F2 / F4 (CLI polling): stopping only on an explicit `found: false`,
tolerating one status-less / non-dict body, and printing a distinct
response-shape / failover message on a repeat is the behaviour I was after.
- F5 (wording): if the only remaining "id may be wrong" text is in
`run_diagnose`'s 404 branch where the id is user-supplied, that resolves the
finding.
- F6 / F8 (UI): `loadError` on initial-load rejection, warn-once-and-retry
on post-load rejection, and `{ jobId }` in `detail.notFound.description` with
the `123456789` assertion all address what I raised.
- F7 (`job_exists`): raising `TypeError` for non-dict / non-JSON before
checking `found` is the right split.
**Remaining asks (none depend on each other, so please provide all in one
go)**
1. For F2/F4, a short paste of the test case(s) in the CLI suite that
exercise the one-tolerated-then-fail path and the "non-dict 200 followed by
`found: false`" path, so I can confirm the retry counter is reset correctly
after a good status response.
2. For F6, confirm whether the "warn once per error streak" counter in
`detail.tsx` resets after a successful refresh — the two `detail.spec.ts` cases
you named cover reject-on-load and reject-after-load, but I don't see one for
reject → success → reject.
3. For F1/F3, a confirmation that the `found: false` example in the
deprecated v2 `/running-job/:jobId` section carries the same deprecation note
as the rest of that section, so readers aren't steered toward the old path by
the new example.
CI being green on the rerun is noted and the Doris container timeout
explanation matches what I'd expect for that suite. Once I have the three items
above I'll post the formal recheck result for F1-F8 and hand off for committer
approval.
<!-- streview-comment:2152 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
