wgzhao commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6570792171
Added both sequences on the new head `fb542b3e9`, in the existing
parametrized `test_polling_stops_when_the_job_is_not_known`
(`seatunnel-cli/tests/test_diagnose_cli.py`):
- `non-dict-body-then-marker`: `[null, {"found": false}]` → 2 polls, ending
with the marker message; the explicit `found: false` wins over the status-less
branch even after a tolerated non-dict body.
- `status-less-good-status-less-then-marker`: `[status-less, RUNNING,
status-less, found: false]` → 4 polls, proving `missing_response_seen` is reset
only after a valid `jobStatus` (without the reset the poll stops on the third
response).
The fake keeps returning a status-less body once the scripted responses run
out, so a regression hits the max-poll bound and fails the call-count assertion
rather than raising `StopIteration` into the poller's catch-all.
Validation on `fb542b3e9`: full `seatunnel-cli` suite `341 passed, 3
subtests passed`; `ruff check .` passes. Only `tests/test_diagnose_cli.py`
changed.
@SEZ9 the head is now `fb542b3e9` and the two sequences are in place — the
formal F1–F8 recheck is yours whenever you're ready. Note the push dismissed
the stale approvals, so the PR is back to `REVIEW_REQUIRED` and a fresh
committer approval will be needed after your recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
