SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6567542823
@wgzhao thanks for the ping, and sorry for the delay on my side. To answer your question directly: yes, please pin the two extra polling sequences (non-dict → `found:false`, and status-less → good → status-less) in the same test function. They are cheap to add and they close out F2/F4 definitively rather than leaving the polling behaviour as an implied property, so I'd rather have them in before I sign off. On the rest, based on the per-item responses in this thread against `4cfc9b02b`: - F1/F3: covering all four EN/ZH REST sections, including the deprecated v2 `/running-job/:jobId` header and its unknown-id example, is exactly what I was after. - F5: separating the user-supplied-id 404 wording from the submit-and-poll path resolves the "id may be wrong" concern. - F6/F8: keeping the populated page on a refresh failure and showing the looked-up id is what I asked for. - F7: raising `TypeError` on a non-dict payload instead of reporting the job as absent is the right call. So the only remaining ask is the two polling sequences. Once those are pushed, I'll do the formal F1–F8 recheck in a single pass over the new head and record the per-item results here so the thread has a clean close. <!-- streview-comment:2207 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
