SEZ9 commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6593780218
@karthik-0306 thanks for closing the loop on F3 lock release. Your reading matches mine: `_exclusive_lock` closes the descriptor in the `finally` (`os.close(fd)`, L226-227), which drops the `flock` on a normal return, on `PluginInstallError` and on `KeyboardInterrupt`, and `test_lock_is_held_while_the_script_runs` already covers the held-while-running side. A dedicated post-failure release test would be nice-to-have at most, so no need to add one here. Please keep the head at `5e82f43` as is; a new commit for that test alone would only reset the review round for no behavioural gain. With the F3-F8 answers matching your notes, I have no remaining source asks on this PR. The rest is on the committer side to wrap up; nothing further is needed from you right now. <!-- streview-comment:2236 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
