nzw921rx commented on code in PR #13238:
URL: https://github.com/apache/seatunnel/pull/13238#discussion_r4638367650
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSink.java:
##########
@@ -90,11 +90,7 @@ public MultiTableSink(MultiTableFactoryContext context) {
this.sinks = context.getSinks();
this.replicaNum =
context.getOptions().get(SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA);
- // replicaNum is the writer count per subtask and becomes the queue
count and the
- // thread-pool size in MultiTableSinkWriter. Below 1 there is no
writer to route a row
- // to, and Executors.newFixedThreadPool rejects the size with a
message-less
- // IllegalArgumentException that names neither this option nor its
value. Fail here
- // instead, with both.
+ // Options can also come from callers that construct the sink directly.
Review Comment:
I think it's no longer necessary here. Once the main creation path is
configured in the optionRule, it can be intercepted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]