DanielLeens commented on PR #12858:
URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6851074495

   Thanks @SEZ9 and @lukas-pastva. Here is the current-source mapping for the 
installer questions in 
`tools/seatunnel-python-sdk/seatunnel/plugin_installer.py`:
   
   - Windows is rejected before any selection write (263-267); the API 
documents a caller-managed distribution, not a shared installation (247-250).
   - Version validation runs before mutation (269-278). `LATEST`, `RELEASE` and 
`*-SNAPSHOT` are intentionally supported Maven modes, explicitly documented at 
253-255; this is not a claim that Maven is never invoked.
   - The distribution and script paths are made absolute before passing `cwd` 
(286-315), preventing a relative path from being applied twice.
   - Connector normalization and UTF-8/line validation happen before the atomic 
replacement. Malformed connector lines, including unsupported trailing 
comments, are rejected rather than silently leaving an unintended selection 
enabled.
   - The exclusive lock covers reading the original bytes, selecting plugins, 
running the script and rollback (301-338).
   - Script errors and interrupts restore the saved bytes; rollback failure is 
surfaced rather than hidden (325-338).
   - The version error asks for the engine-matching version, without 
recommending a hard-coded release (269-277).
   
   These are source pointers for your existing questions, not new executed 
tests or a dismissal of your review. The prior technical conclusion remains 
unchanged; please reconcile your findings against this head when ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to