SEZ9 commented on PR #12327:
URL: https://github.com/apache/seatunnel/pull/12327#issuecomment-6961009930

   @Dev-next-gen Thanks. Tracking the deduplication in the issue you opened 
settles the three-copies point for this PR, and nothing further is needed from 
you here on that. Leaving the "willing to submit a PR" box unchecked is fine, 
and the dedup does not have to land in this PR.
   
   You mentioned the branch head is still 4be680c2e with no code change, and I 
don't see the other review points answered in this thread. Could you say where 
each one stands?
   
   1. **Unbalanced or unterminated quote.** The scanner swallows the rest of 
the column list and returns an empty or partial map with no error. Please make 
the parser fail with a clear message when it ends while still inside a quote.
   2. **Backslash inside backtick identifiers.** It is treated as an escape 
there, but the identifier escape is the doubled backtick. A `\` immediately 
before a closing backtick consumes it and desynchronises the scanner.
   3. **Test coverage.** The test only pins `'...'` literals with the `\'` 
escape. Please add cases for double-quoted literals, backtick identifiers 
containing `,` or `)`, `''` doubling, and offsets for a column that comes after 
a `\`-escape. You mention a MaxCompute copy of `CreateTableParserTest`: does it 
cover these cases while that copy is still live?
   4. **Javadoc.** `getColumnList` still needs a short description of its 
quoting and escape contract.
   
   If you would rather defer any of these, tell me which and why, and we can 
decide whether it belongs in this PR or a follow-up.
   
   <!-- streview-comment:2403 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to