Dev-next-gen commented on PR #12327:
URL: https://github.com/apache/seatunnel/pull/12327#issuecomment-6961679813

   @SEZ9 Sorry, my "no code change since" was ambiguous. It meant nothing was 
pushed after 4be680c2e, and 4be680c2e is the commit that holds all four changes 
(pushed on Nov 15, after your review). Here they are in the connector-common 
copy. The MaxCompute and ClickHouse copies are byte-identical apart from the 
package line.
   
   1. Unterminated quote: after the loop, 
[`CreateTableParser.java:83-86`](https://github.com/apache/seatunnel/blob/4be680c2e85da19681543b3de1fd1dd74878c6bf/seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTableParser.java#L83-L86)
 throws `IllegalArgumentException("Unterminated " + quote + " quote in 
save_mode_create_template")`.
   2. Backslash in backticks: the escape branch at 
[`CreateTableParser.java:59`](https://github.com/apache/seatunnel/blob/4be680c2e85da19681543b3de1fd1dd74878c6bf/seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTableParser.java#L59)
 is guarded by `` quote != '`' ``, so it only applies inside `'...'` and 
`"..."`.
   3. Tests: 
[`testDelimitersInsideQuotedTextDoNotSplitColumns`](https://github.com/apache/seatunnel/blob/4be680c2e85da19681543b3de1fd1dd74878c6bf/seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTableParserTest.java#L29-L59)
 checks the offsets of a bare `creator` placed after `'it\'s a, b'`. 
[`testDoubleQuotesBackticksAndDoubledQuotes`](https://github.com/apache/seatunnel/blob/4be680c2e85da19681543b3de1fd1dd74878c6bf/seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTableParserTest.java#L62-L85)
 covers `"low,medium)"`, `'it''s, a'`, `` `p,q` ``, `` `path\` `` followed by a 
bare column, and the offsets of `creator` after them. 
[`testUnterminatedQuoteFails`](https://github.com/apache/seatunnel/blob/4be680c2e85da19681543b3de1fd1dd74878c6bf/seatunnel-connectors-v2/connector-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTabl
 eParserTest.java#L87-L97) covers the unterminated quote. The MaxCompute 
`CreateTableParserTest` has the same three tests.
   4. Javadoc: 
[`CreateTableParser.java:31-44`](https://github.com/apache/seatunnel/blob/4be680c2e85da19681543b3de1fd1dd74878c6bf/seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTableParser.java#L31-L44).
   
   I just reran both test classes at 4be680c2e on JDK 17: `Tests run: 3, 
Failures: 0, Errors: 0, Skipped: 0` for `common.util.CreateTableParserTest`, 
the same for `maxcompute.util.CreateTableParserTest`, and `BUILD SUCCESS`.
   
   Found by a defect-hunting pipeline I build and run 
([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with 
Anthropic's Claude Opus 5.5.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to