SEZ9 commented on PR #12327:
URL: https://github.com/apache/seatunnel/pull/12327#issuecomment-6991673098
@Dev-next-gen Thanks for the clarification. Understood: nothing was pushed
after 4be680c2e, and that commit, pushed on Nov 15 after the review, holds all
four changes.
I haven't verified the commit yet, so I'm not marking the earlier points
resolved on the description alone. These are the points I'll check against it:
1. **Unterminated quote**: you describe an `IllegalArgumentException` thrown
after the loop. I'll confirm that the template now fails at the parser instead
of returning a partial map.
2. **Backslash in backtick identifiers**: you describe the escape branch as
applying only inside single-quoted and double-quoted text. I'll confirm that a
backslash right before a closing backtick no longer desynchronises the scanner.
3. **Tests**: I'll check coverage for:
- double-quoted literals and backtick identifiers containing `,` or `)`
- the `''` doubling form
- the offset bookkeeping for a column that comes after a backslash escape
- the MaxCompute copy
4. **Javadoc**: I'll check whether `getColumnList` now documents the quoting
and escape contract.
Two things I need from you:
- **Truncated comment**: your comment reached me cut off partway through
point 3, at the link to `testDelimitersInsideQuotedTextDoNotSplitColumns`.
Could you repost the rest, including the fourth change?
- **Three copies**: you mention the MaxCompute and ClickHouse copies are
byte-identical apart from the package line, so the duplication is still there.
The ClickHouse copy is unreferenced and MaxCompute already depends on
connector-common. Would you be open to dropping the duplicates in this PR? If
not, what would guard them against drifting?
<!-- streview-comment:2426 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]