The GitHub Actions job "Required Checks" on texera.git/xinyuan-loop-feb has 
failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
043ed302c3193bbf217f256abb59b6b063c4c9af / Xinyuan Lin <[email protected]>
test(loop): cover the output-storage reuse decision in 
RegionExecutionCoordinator

Addresses the remaining half of PR #4206 review feedback
(https://github.com/apache/texera/pull/4206#discussion_r3400851511): the
skip-create branch (reuse an existing output document on region re-run
instead of clobbering it) was untested. (The rename half landed in
3d4f15b445.)

Extract the create-or-reuse decision out of the private
createOutputPortStorageObjects into a pure companion method
RegionExecutionCoordinator.provisionOutputDocument(uri,
reuseExistingStorage, documentExists, createDocument) with the storage
operations injected, so the four cases can be unit-tested without an
iceberg backend or a live region.

New RegionOutputProvisioningSpec pins:
* reuse + existing document  -> NOT recreated (createDocument not called),
  so accumulated loop output survives the re-run;
* reuse + no document yet     -> created (first iteration);
* no-reuse + existing         -> recreated/overwritten (fresh per run);
* no-reuse + none             -> created;
* no-reuse short-circuits documentExists (always recreate, never probe).

Verified the production change compiles (the only remaining amber
compile errors are the pre-existing PveManager/virtual_environments JOOQ
issue from #5577, unrelated to this change and resolved by a migrated DB
in CI); the new spec is a pure ScalaTest unit with no iceberg/actor
dependency.

Report URL: https://github.com/apache/texera/actions/runs/27450946330

With regards,
GitHub Actions via GitBox

Reply via email to